chore: set correct parameter names #2975
Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates parameter names in the GitHub Actions workflow to use the correct format with hyphens instead of underscores for the actions/create-github-app-token@v2 action, and removes the unnecessary installation_id parameter.
- Changed parameter names from underscore format to hyphen format (
app_id→app-id,private_key→private-key) - Removed the
installation_idparameter which is not required for this action
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| private_key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }} | ||
| installation_id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_INSTALLATION_ID }} | ||
|
|
||
| app-id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }} |
There was a problem hiding this comment.
The parameter name should be app_id with underscores, not app-id with hyphens. According to the actions/create-github-app-token@v2 documentation, the correct parameter name is app_id.
| app-id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }} | |
| app_id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }} |
There was a problem hiding this comment.
Copilot, you are hallucinating. Please review the documentation again.
| installation_id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_INSTALLATION_ID }} | ||
|
|
||
| app-id: ${{ vars.RELEASE_PLEASE_TOKEN_PROVIDER_APP_ID }} | ||
| private-key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }} |
There was a problem hiding this comment.
The parameter name should be private_key with underscores, not private-key with hyphens. According to the actions/create-github-app-token@v2 documentation, the correct parameter name is private_key.
| private-key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }} | |
| private_key: ${{ secrets.RELEASE_PLEASE_TOKEN_PROVIDER_PEM }} |
There was a problem hiding this comment.
Copilot, you are hallucinating. Please review the documentation again.
Installation id is not necessary
Microsoft Reviewers: Open in CodeFlow